Skip to content

test: better categorize some Document Stores tests#3085

Merged
anakin87 merged 1 commit into
mainfrom
better-tests-categorization-docstores
Apr 2, 2026
Merged

test: better categorize some Document Stores tests#3085
anakin87 merged 1 commit into
mainfrom
better-tests-categorization-docstores

Conversation

@anakin87
Copy link
Copy Markdown
Member

@anakin87 anakin87 commented Apr 1, 2026 •
edited
Loading

Related Issues

I realized that in Document Stores we sometimes have some unit tests marked as integration tests.
(In Chroma, the opposite happens.)

Proposed Changes:

  • better categorize Document Stores tests
  • transform a low number of integration tests into unit tests when straightforward
  • remove redundant @pytest.mark.integration, when the test is already contained in a marked class

How did you test it?

CI

Checklist

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 1, 2026

Coverage report (mongodb_atlas)

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  integrations/mongodb_atlas/src/haystack_integrations/document_stores/mongodb_atlas
  document_store.py
Project Total  

This report was generated by python-coverage-comment-action

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 1, 2026

Coverage report (chroma)

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  integrations/chroma/src/haystack_integrations/document_stores/chroma
  document_store.py
  filters.py
Project Total  

This report was generated by python-coverage-comment-action

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 1, 2026

Coverage report (valkey)

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  integrations/valkey/src/haystack_integrations/components/retrievers/valkey
  embedding_retriever.py
Project Total  

This report was generated by python-coverage-comment-action

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 1, 2026

Coverage report (elasticsearch)

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  integrations/elasticsearch/src/haystack_integrations/document_stores/elasticsearch
  document_store.py
Project Total  

This report was generated by python-coverage-comment-action

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 1, 2026

Coverage report (opensearch)

This PR does not seem to contain any modification to coverable code.

@anakin87 anakin87 marked this pull request as ready for review April 1, 2026 15:42
@anakin87 anakin87 requested a review from a team as a code owner April 1, 2026 15:42
@anakin87 anakin87 requested review from sjrl and removed request for a team April 1, 2026 15:42
@anakin87 anakin87 self-assigned this Apr 1, 2026
sjrl
sjrl approved these changes Apr 2, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@sjrl sjrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@anakin87 anakin87 merged commit 471d174 into main Apr 2, 2026
33 checks passed
@anakin87 anakin87 deleted the better-tests-categorization-docstores branch April 2, 2026 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sjrl sjrl sjrl approved these changes

Assignees

@anakin87 anakin87

Labels

integration:chroma integration:elasticsearch integration:mongodb-atlas integration:opensearch integration:valkey type:documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@anakin87 @sjrl